Refetch query on draft creation #9650
Merged
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented refetch query functionality in the workflow draft creation process to ensure data consistency after redirecting users to the workflow page.
- Added refetchQueries configuration in
packages/twenty-front/src/modules/workflow/hooks/useCreateDraftFromWorkflowVersion.tsto update workflow cache after draft creation - Added
findManyWorkflowsQueryto handle workflow data synchronization - Added 'Suspended' status to WorkspaceActivationStatus enum in GraphQL schema
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
martmull
reviewed
Jan 16, 2025
| @@ -1532,7 +1532,8 @@ export enum WorkspaceActivationStatus { | |||
| Active = 'ACTIVE', | |||
| Inactive = 'INACTIVE', | |||
| OngoingCreation = 'ONGOING_CREATION', | |||
| PendingCreation = 'PENDING_CREATION' | |||
| PendingCreation = 'PENDING_CREATION', | |||
| Suspended = 'SUSPENDED' | |||
martmull
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hitting use as draft, we redirect the user to the workflow page. If the user already accessed that page, the workflow and its current version will be stored in cache. So we also need to update that cache.
I tried to update it manually but it was more complex than expected. Steps and trigger are not fully defined objects.
I ended with a simple refetch query that I wanted to avoid but that is at least fully working with minimum logic.